feat(web-analytics): Session filters 1 #21512

robbie-c · 2024-04-12T11:29:17Z

Problem

Need session filters for web analytics and personless events

Changes

Make it work

Can query using session property filters in event scope and session scope in hogql
Can fetch session property filters in TaxonomicFilter UI
Can fetch session property values in TaxonomicFilter UI
Each session property filter has an entry in Taxonomy.ts
Existing tests pass or are updated to pass

Make it right

Taxonomy.ts entires are fully formed, with nice descriptions and examples
Good error message if you try to use a session filter where it isn't valid (i.e. not hogql)
Test coverage for the new functions to get properties and values
Only visible in web analytics (for now) and only with a FF

Make it fast

Query the property values from raw sessions rather than needing to aggregate anything

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Tests are part of my checklist above

github-actions · 2024-04-12T11:40:28Z

Size Change: +488 B (0%)

Total Size: 1.04 MB

ℹ️ View Unchanged

Filename	Size	Change
`frontend/dist/toolbar.js`	1.04 MB	+488 B (0%)

_{compressed-size-action}

posthog-bot · 2024-04-12T11:41:26Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-04-12T11:51:26Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-04-12T14:33:01Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-04-12T14:43:00Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-04-15T21:11:01Z

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

chromium: 0 added, 3 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-04-16T10:26:10Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-04-16T16:29:57Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-04-16T20:25:16Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-04-16T20:34:54Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-04-16T21:33:38Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-04-18T13:01:22Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-04-18T13:11:31Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-04-18T13:20:58Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-04-18T13:30:51Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-04-18T13:41:25Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-04-18T13:51:27Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-04-18T14:20:32Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-04-18T14:30:45Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

…SessionProperties

mariusandra

Read through the code and looks good. Ran and everything worked. So here's a ✅ from me.

A future improvement would be to add these session properties to even more places, like the Activity page, person pages, etc. (Groups should also be added to more places now)

mariusandra · 2024-04-25T14:55:23Z

frontend/src/lib/api.ts

+    sessions: {
+        async propertyDefinitions({
+            teamId = ApiConfig.getCurrentTeamId(),
+            search,
+            properties,
+        }: {
+            teamId?: TeamType['id']
+            search?: string
+            properties?: string[]
+        }): Promise<CountedPaginatedResponse<PropertyDefinition>> {
+            return new ApiRequest()
+                .sessionPropertyDefinitions(teamId)
+                .withQueryString(toParams({ search, ...(properties ? { properties: properties.join(',') } : {}) }))
+                .get()
+        },
+    },


No pagination?

Probably no need to add it to the definitions endpoint, but I should add it to the values endpoint. I'll fix this in a future PR

robbie-c mentioned this pull request Apr 12, 2024

feat(web-analytics): Allow other session properties beyond $session_duration #21515

Merged

robbie-c force-pushed the feat/session-filters-1 branch 2 times, most recently from 0c31742 to d5c3495 Compare April 12, 2024 14:04

robbie-c force-pushed the feat/session-filters-1 branch from de71718 to 9566ea4 Compare April 15, 2024 20:58

robbie-c force-pushed the feat/session-filters-1 branch from 6ef03ae to 61948ce Compare April 16, 2024 10:16

robbie-c force-pushed the feat/session-filters-1 branch from 1c824af to 6a06696 Compare April 16, 2024 20:15

robbie-c force-pushed the feat/session-filters-1 branch from d0f8936 to 4ae265f Compare April 16, 2024 21:24

robbie-c force-pushed the feat/session-filters-1 branch 2 times, most recently from e59e073 to 23054b5 Compare April 18, 2024 12:41

robbie-c marked this pull request as ready for review April 18, 2024 12:42

robbie-c force-pushed the feat/session-filters-1 branch from 4b6dcc6 to 7ec47f6 Compare April 18, 2024 13:35

robbie-c and others added 23 commits April 25, 2024 09:54

Put session properties first

6c2bced

Add session values

a0a07aa

Rename duration back to $session_duration

7ea52bc

Fix "keeps infiniteListCounts in sync"

e666f6f

Fix "setting search query filters events"

eba45b6

Fix taxonomy tests

50afd65

Change session api to GenericViewSet

6ceb302

Add local properties back

200b09a

Support datetime and boolean session properties

7f77e5f

Update mypy baseline

68c1a88

Hide duration as a property and asterisk field

0db6248

Add AsyncReturnType

dbda731

Make taxonoicFilterLogic tests more reliable (maybe)

cb2fb3b

Fix duplicates from bad rebase

870334a

Only show session table session properties if feature flag enabled

5658a57

Improve error message for non-hogql non-duration session property

888a1da

Put session table properties behind FF

085e150

Revert taxonomicFilterLogic tests

c7c3a9a

Update query snapshots

f5ef830

Rename TaxonomicFilterGroupType.Sessions to TaxonomicFilterGroupType.…

350f046

…SessionProperties

Use ViewSet instead of GenericViewSet

569b873

Add tests for session properties and session property values api

0332190

Formatting

0ec3bf1

robbie-c force-pushed the feat/session-filters-1 branch from 9f2cf28 to 0ec3bf1 Compare April 25, 2024 08:56

robbie-c requested a review from a team April 25, 2024 08:56

robbie-c and others added 2 commits April 25, 2024 10:03

New typing

5ab36e1

Update query snapshots

6cd2c85

mariusandra approved these changes Apr 25, 2024

View reviewed changes

robbie-c merged commit e3acb16 into master Apr 25, 2024
106 checks passed

robbie-c deleted the feat/session-filters-1 branch April 25, 2024 15:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(web-analytics): Session filters 1 #21512

feat(web-analytics): Session filters 1 #21512

robbie-c commented Apr 12, 2024 •

edited

Loading

github-actions bot commented Apr 12, 2024 •

edited

Loading

posthog-bot commented Apr 12, 2024

posthog-bot commented Apr 12, 2024

posthog-bot commented Apr 12, 2024

posthog-bot commented Apr 12, 2024

posthog-bot commented Apr 15, 2024

posthog-bot commented Apr 16, 2024

posthog-bot commented Apr 16, 2024

posthog-bot commented Apr 16, 2024

posthog-bot commented Apr 16, 2024

posthog-bot commented Apr 16, 2024

posthog-bot commented Apr 18, 2024

posthog-bot commented Apr 18, 2024

posthog-bot commented Apr 18, 2024

posthog-bot commented Apr 18, 2024

posthog-bot commented Apr 18, 2024

posthog-bot commented Apr 18, 2024

posthog-bot commented Apr 18, 2024

posthog-bot commented Apr 18, 2024

mariusandra left a comment

mariusandra Apr 25, 2024

robbie-c Apr 25, 2024

feat(web-analytics): Session filters 1 #21512

feat(web-analytics): Session filters 1 #21512

Conversation

robbie-c commented Apr 12, 2024 • edited Loading

Problem

Changes

Make it work

Make it right

Make it fast

Does this work well for both Cloud and self-hosted?

How did you test this code?

github-actions bot commented Apr 12, 2024 • edited Loading

posthog-bot commented Apr 12, 2024

📸 UI snapshots have been updated

posthog-bot commented Apr 12, 2024

📸 UI snapshots have been updated

posthog-bot commented Apr 12, 2024

📸 UI snapshots have been updated

posthog-bot commented Apr 12, 2024

📸 UI snapshots have been updated

posthog-bot commented Apr 15, 2024

📸 UI snapshots have been updated

posthog-bot commented Apr 16, 2024

📸 UI snapshots have been updated

posthog-bot commented Apr 16, 2024

📸 UI snapshots have been updated

posthog-bot commented Apr 16, 2024

📸 UI snapshots have been updated

posthog-bot commented Apr 16, 2024

📸 UI snapshots have been updated

posthog-bot commented Apr 16, 2024

📸 UI snapshots have been updated

posthog-bot commented Apr 18, 2024

📸 UI snapshots have been updated

posthog-bot commented Apr 18, 2024

📸 UI snapshots have been updated

posthog-bot commented Apr 18, 2024

📸 UI snapshots have been updated

posthog-bot commented Apr 18, 2024

📸 UI snapshots have been updated

posthog-bot commented Apr 18, 2024

📸 UI snapshots have been updated

posthog-bot commented Apr 18, 2024

📸 UI snapshots have been updated

posthog-bot commented Apr 18, 2024

📸 UI snapshots have been updated

posthog-bot commented Apr 18, 2024

📸 UI snapshots have been updated

mariusandra left a comment

Choose a reason for hiding this comment

mariusandra Apr 25, 2024

Choose a reason for hiding this comment

robbie-c Apr 25, 2024

Choose a reason for hiding this comment

robbie-c commented Apr 12, 2024 •

edited

Loading

github-actions bot commented Apr 12, 2024 •

edited

Loading